fix(extension): [lw-10782] add proper mappers for missed conway era certs #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
smokeTests: ✅ test report for 7e3cd8bc
|
mirceahasegan
approved these changes
Jun 21, 2024
vetalcore
force-pushed
the
fix/lw-10782-map-conway-era-certificates
branch
2 times, most recently
from
dbed7ac to
ff8f22d
Compare
vetalcore
commented
Jun 24, 2024
| @@ -22,6 +22,7 @@ export const useWalletActivities = ({ | |||
|
|
|||
| const fetchWalletActivities = useCallback(async () => { | |||
| fiatCurrency && | |||
| cardanoFiatPrice && | |||
There was a problem hiding this comment.
there is a case when cardanoFiatPrice comes as undefined from useFetchCoinPrice
removing memoize util that is a hoc around mapWalletActivities also helps, but i'm not able to debug why resolver is not reevaluating the key correctly.
| @@ -43,7 +43,7 @@ export const getFormattedFiatAmount = ({ | |||
| return fiatAmount ? `${fiatAmount} ${fiatCurrency.code}` : '-'; | |||
| }; | |||
|
|
|||
| const splitDelegationTx = (tx: TransformedActivity): TransformedTransactionActivity[] => { | |||
| const splitDelegationTx = (tx: TransformedActivity, hasConwayEraCerts: boolean): TransformedTransactionActivity[] => { | |||
There was a problem hiding this comment.
we could consider to refactor that at some point, maybe to hoist that into tx-inspection, so it could return an array of types.
@mchappell wdyt?
maybe we could create a tech debt ticket?
vetalcore
force-pushed
the
fix/lw-10782-map-conway-era-certificates
branch
4 times, most recently
from
b974066 to
e2fadc0
Compare
…erts in activities transformers
…ate between conway and non
vetalcore
force-pushed
the
fix/lw-10782-map-conway-era-certificates
branch
from
69ca3f4 to
7e3cd8b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add proper mappers for missed conway era certs
Checklist
Proposed solution
Extend tx inspection related mappers with missed conway era certs.
Testing
Follow the steps in the description of the ticket.
Screenshots